Added data source google kms secret asymmetric #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ghost
requested a review
from 
mvanholsteijn
changed the title
dennisvink
approved these changes
Mar 13, 2021
|
Hi @melinath I am looking forward to your review! Just let me know if you have any questions for me, or whether I have to change things here. |
melinath
requested changes
Mar 16, 2021
There was a problem hiding this comment.
Hello, thanks for your PR! This API looks like a GA api; I'll need to upstream your changes to https://github.com/GoogleCloudPlatform/magic-modules, after which they'll be put into both the beta and GA providers. Does that seem correct?
This implementation seems fine; I just have a couple questions.
melinath
approved these changes
Mar 19, 2021
5 tasks
|
@melinath great! Thank you! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the data source
google_kms_secret_asymmetric. I chose to put_asymmetricas a suffix to ensure that in the documentation it will appear next togoogle_kms_secret.This partly deals with issue hashicorp/terraform-provider-google#6462