Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gkehub Membership Resource [updated again] #3079

Conversation

modular-magician
Copy link
Collaborator

Mirrors GoogleCloudPlatform/magic-modules#4545

Remove some non-useful fields, add authority.issuer

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_gke_hub_membership`

Derived from GoogleCloudPlatform/magic-modules#4600

* GKE Hub Membership resource.

* Update api.yaml

* Update to remove fields, add update capabilities

* Add issuer to test

* Add issuer, authority to test

* Add additional test

Co-authored-by: Nathan Mckinley <nmckinley@google.com>
Co-authored-by: Nathan McKinley <nath@nmckinley.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xxl label Mar 23, 2021
@modular-magician modular-magician merged commit 96d68ce into hashicorp:master Mar 23, 2021
@modular-magician modular-magician deleted the downstream-pr-9d0a00f2dd79ed96655a3b3e849b2789b42c8a1d branch November 16, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant