Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloud_identity): google_cloud_identity_group_membership import/update #3136

Conversation

modular-magician
Copy link
Collaborator

Fixed bugs in google_cloud_identity_group_membership:

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
    • 👉 I can't run the exact acctests because I don't have a permission to create groups in my organization. However, I ran them with hardcoding an existing group ID and confirmed they passed.
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloud_identity: fix google_cloud_identity_group_membership import/update

Derived from GoogleCloudPlatform/magic-modules#4658

…date (hashicorp#4658)

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xl label Apr 7, 2021
@modular-magician modular-magician merged commit 0f6ecb5 into hashicorp:master Apr 7, 2021
@modular-magician modular-magician deleted the downstream-pr-fb4516b4eaeedb73655b00a35db3fa0a542ed4f5 branch November 16, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating a google_cloud_identity_group_membership to remove a role fails with an error
1 participant