Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for InitialGroupConfig to google_cloud_identity_group #3211

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#7986.

If you change the value of initial_group_config after creation, as this PR is written, the group will be destroyed and recreated. Let me know if you'd like me to look at alternative behaviors here (e.g., being a no-op).

Thanks!

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).

  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.

  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).

  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).

    ▶️ I had trouble figuring out if the acceptance tests support selecting a billing project to use and our service accounts don't have permissions to create groups. However, I tested this change by hand in a separate module and it works.

  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloud_identity: add support for `initial_group_config` to the google_cloud_identity_group resource

Derived from GoogleCloudPlatform/magic-modules#4746

…shicorp#4746)

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added size/s labels Apr 29, 2021
@modular-magician modular-magician merged commit da99660 into hashicorp:master Apr 29, 2021
@modular-magician modular-magician deleted the downstream-pr-dd8526019b3dec1b4cf727296bf10c2eb1b3077c branch November 16, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support InitialGroupConfig in google_cloud_identity_group
1 participant