Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add transform error function for security policy association read error #3234

Conversation

modular-magician
Copy link
Collaborator

Upstream won't change not found error to 404, so will have to transform it here
Fixes hashicorp/terraform-provider-google#7168

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: fixed bug where, when an organization security policy association was removed outside of terraform, the next plan/apply would fail.

Derived from GoogleCloudPlatform/magic-modules#4765

…or (hashicorp#4765)

* add transform error function for security policy assocaition read error

* beta only

* move package line out

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/s label May 6, 2021
@modular-magician modular-magician merged commit 0aaab2a into hashicorp:master May 6, 2021
@modular-magician modular-magician deleted the downstream-pr-f83e41db6c3a692940133d1d45b93895c74ed7e9 branch November 16, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant