Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample #3253

Conversation

modular-magician
Copy link
Collaborator

Resolved hashicorp/terraform-provider-google#8937.

Switched off the default service to a new one.

This test relies on an app engine instance; the failure was in app engine initialization rather than in the configuration that was actually needing to be tested. I copied the configuration from a passing app engine test, and this now passes.

This pr also changes the line endings in the template file, so it might be useful to turn on whitespace ignoring to review.

Run of just this test: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/185685

This does end up taking about 2x as long as the test previously took (i.e. 8min instead of 4min); I'm definitely open to suggestions if you have any!

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#4761

…roupAppengineExample (hashicorp#4761)

* Switched app name to not use default

* Added note re: allowed characters to service field

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label May 14, 2021
@modular-magician modular-magician merged commit 93588d7 into hashicorp:master May 14, 2021
@modular-magician modular-magician deleted the downstream-pr-6bf2e4eacf5723d21d7d1424707cedde9994fafb branch November 16, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant