Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle failed flex job template updates #3279

Conversation

andremarianiello
Copy link
Contributor

This small changes improves the handling of an updating flex template job by waiting for the new job to be in a RUNNING state. Previously, we were waiting for the old job to terminate in some fashion, which won't happen if the new job fails to launch for some reason. This change ensures that the provider is not stuck in a "Still waiting..." loop until timing out. This issue was mentioned in hashicorp/terraform-provider-google#8408 (comment) on hashicorp/terraform-provider-google#8408

@andremarianiello
Copy link
Contributor Author

@ScottSuarez please let me know if there is anything more I should do for this.

@ScottSuarez
Copy link
Collaborator

Hey sorry, I'm off on vacation until next Tuesday. I'll take a look then. Thanks for your patience

@ScottSuarez
Copy link
Collaborator

I see so instead of waiting for the old job to be updated you are now going to wait for the new job to be running. Let me run this test locally since it's skipping the vcr

@andremarianiello
Copy link
Contributor Author

@melinath
Copy link
Collaborator

melinath commented Jun 7, 2021

Superseded by the upstream PR.

@melinath melinath closed this Jun 7, 2021
@andremarianiello andremarianiello deleted the updateable-flex-template-jobs branch June 7, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants