Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying node pool cluster as a long-form id #3314

Conversation

modular-magician
Copy link
Collaborator

This allows users to specify an id-based relationship between the two, which will ensure the node pool is automatically re-created when the cluster is re-created. (This is a core behavior of terraform.)

Resolved hashicorp/terraform-provider-google#9220.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: Allowed specifying a cluster id field for `google_container_node_pool.cluster` to ensure that a node pool is recreated if the associated cluster is recreated.

Derived from GoogleCloudPlatform/magic-modules#4842

This allows users to specify an id-based relationship between the two, which will ensure the node pool is automatically re-created when the cluster is re-created.

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 4c07af1 into hashicorp:master Jun 4, 2021
@modular-magician modular-magician deleted the downstream-pr-64478da9eda2161ec7d3059b2c13296916d59ff4 branch November 16, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster does not recreate or reattach node pools if a change requires cluster respin.
1 participant