Made dataflow job updates fail fast if they're cancelled #3317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved hashicorp/terraform-provider-google#9227.
Dataflow flex template jobs that are CANCELLING or DRAINING will never be able to be RUNNING. If we're expecting RUNNING but seeing CANCELLING or DRAINING, we can fail fast and let the user know (instead of making them wait for a few minutes.)
An alternative implementation would be to "update" the job by actually creating a new job (i.e. not using the update mechanism provided by dataflow flex templates.) However, that seems potentially confusing for end users. That would need some discussion as a potential enhancement, rather than a bug.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#4845