Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gkehub Feature/FeatureMembership #3330

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Gkehub Feature/FeatureMembership #3330

merged 1 commit into from
Jun 10, 2021

Conversation

modular-magician
Copy link
Collaborator

Fixes: hashicorp/terraform-provider-google#8446

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_gkehub_feature

google_gkehub_feature_membership

Derived from GoogleCloudPlatform/magic-modules#4812

@modular-magician
Gkehub Feature/FeatureMembership (hashicorp#4812)
210f316 
* Add cmek to spanner database

* Update timeout

* Mark test as beta

* Move to handwritten test

* Adding dcl for gkehub feature

* Mostly working

* Add extra test steps

* Getting closer, still fails with hierarchy controller set

* Updating test, when to use empty struct

* Remove service account, use empty string instead of nil

* Remove tests on field that is broken

* Add project setup to test

* Updating test

* Use beta provider

* Add dependencies

* Add gkehub service

* Add mcsd

* Add project

* Add deletion

* Add deletion

* Add deletion

* Update yamls, add hierarchy controller tests

* Update tests to use separate projects

* Fix infinite recursion

* Too many projects

* Spacing

* Add dependency for ACM API for ACM test

* Make test use newly created project for checks

* Updating base path

* Adding handwritten basepath for feature specifically

* Remove sweeper, add mcsd test

* Remove VCR for gkehub tests, project services are batched'

* Update markdowns

* Add api link

* PR feedback, rename product

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 4e8d954 into hashicorp:master Jun 10, 2021
@modular-magician modular-magician deleted the downstream-pr-d454bab4a1c453b314eefcf065c458b7a868fa59 branch November 16, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

b/162441967
1 participant
@modular-magician