Feat: add compute network performance config block #3341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
This PR adds the
network_performance_config
block to each ofresource_compute_instance
,resource_compute_instance_from_template
, andresource_compute_instance_template
. Resolves hashicorp/terraform-provider-google#8735If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.TODO:
This change SHOULD only apply toward the beta provider - I need to add the conditional rendering logic to make that happen.- resolvedMy go isn't sharp enough to understand what's going on with the test case panicking here (I'm a humble baby gopher). A disk and image are successfully created but as the VM comes up, the test panics and I don't see why or know what steps to take to debug it. When this is resolved, I can absolutely go back and add similar tests to the other related resources. Any help here is appreciated- resolvedRelease Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#4817