Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add compute network performance config block #3341

Conversation

modular-magician
Copy link
Collaborator

What is this change?

This PR adds the network_performance_config block to each of resource_compute_instance, resource_compute_instance_from_template, and resource_compute_instance_template. Resolves hashicorp/terraform-provider-google#8735

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

TODO:

  1. This change SHOULD only apply toward the beta provider - I need to add the conditional rendering logic to make that happen. - resolved
  2. My go isn't sharp enough to understand what's going on with the test case panicking here (I'm a humble baby gopher). A disk and image are successfully created but as the VM comes up, the test panics and I don't see why or know what steps to take to debug it. When this is resolved, I can absolutely go back and add similar tests to the other related resources. Any help here is appreciated - resolved

Release Note Template for Downstream PRs (will be copied)

compute: added a `network_performance_config` block to each of `resource_compute_instance`, `resource_compute_instance_from_template`, and `resource_compute_instance_template`

Derived from GoogleCloudPlatform/magic-modules#4817

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit f173296 into hashicorp:master Jun 15, 2021
@modular-magician modular-magician deleted the downstream-pr-6c5515101390c80615c3d64bc56237d9a329b04b branch November 16, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Advanced Networking
1 participant