Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hierarchical firewall policies #3556

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Hierarchical firewall policies #3556

merged 1 commit into from
Aug 23, 2021

Conversation

modular-magician
Copy link
Collaborator

Based on the DCL

Fixes: hashicorp/terraform-provider-google#8229

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_compute_firewall_policy_rule

google_compute_firewall_policy_association

google_compute_firewall_policy

Derived from GoogleCloudPlatform/magic-modules#5090

@modular-magician
Hierarchical firewall policies (hashicorp#5090)
4299d7d 
* Send empty instead of nil array

* Adding hierarchical firewall rules

* Update firewall policy yamls

* Fix test:

* Add markdown for hierarchical firewall policies

* PR review

* Add auto id renaming

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 3726be4 into hashicorp:master Aug 23, 2021
@juliocc juliocc mentioned this pull request Oct 14, 2021
Merged
@modular-magician modular-magician deleted the downstream-pr-a25e183bd773eed9fab27e7e245affe7e0c07f68 branch November 16, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support hierarchical firewall policies at GA
1 participant
@modular-magician