Initial autogeneration of Spanner instance in Terraform. #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| if err := d.Set("display_name", flattenSpannerInstanceDisplayName(res["displayName"], d)); err != nil { | ||
| return fmt.Errorf("Error reading Instance: %s", err) | ||
| } | ||
| if err := d.Set("num_nodes", flattenSpannerInstanceNum_nodes(res["nodeCount"], d)); err != nil { |
There was a problem hiding this comment.
In an ideal world, this wouldn't be Num_nodes - but I can live with it.
modular-magician
force-pushed
the
codegen-pr-1266
branch
from
f5aadbc to
7f0a799
Compare
modular-magician
force-pushed
the
codegen-pr-1266
branch
3 times, most recently
from
62fd4c5 to
25defce
Compare
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
force-pushed
the
codegen-pr-1266
branch
from
25defce to
20db284
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @ndmckinley