Revert google_dns_record_set to previous implementation
#3625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#9257
Fixes hashicorp/terraform-provider-google#9112
Fixes hashicorp/terraform-provider-google#9416
This PR reverts the resource to the original handwritten version that uses the DNS client library from the MM-generated version that used the new API.
Deviations from the old handwritten version include:
ttlwas made optional in the previous iteration, I am keeping it optional for backwards-compatibilitytypefield can be updated which is a part of the ID. This allows one of the newer tests to import correctlyRelease Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#5191