Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): added region tags for PrivateCa samples for inclusion in cgc #3967

Merged
merged 1 commit into from
Jan 7, 2022
Merged

docs(samples): added region tags for PrivateCa samples for inclusion in cgc #3967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/5591.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:none

```
1 change: 0 additions & 1 deletion google-beta/resource_privateca_certificate_authority_generated_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ resource "google_privateca_certificate_authority" "default" {
ca_options {
is_ca = true
# Force the sub CA to only issue leaf certs
zero_max_issuer_path_length = true
max_issuer_path_length = 0
}
key_usage {
Expand Down
8 changes: 3 additions & 5 deletions google-beta/resource_privateca_certificate_generated_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ resource "google_privateca_certificate" "default" {
locality = "mountain view"
province = "california"
street_address = "1600 amphitheatre parkway"
}
}
subject_alt_name {
email_addresses = ["email@example.com"]
ip_addresses = ["127.0.0.1"]
Expand All @@ -112,7 +112,6 @@ resource "google_privateca_certificate" "default" {
}
x509_config {
ca_options {
non_ca = true
is_ca = false
}
key_usage {
Expand Down Expand Up @@ -201,8 +200,8 @@ resource "google_privateca_certificate_template" "template" {
aia_ocsp_servers = ["string"]

ca_options {
is_ca = false
max_issuer_path_length = 6
is_ca = false
max_issuer_path_length = 6
}

key_usage {
Expand Down Expand Up @@ -452,7 +451,6 @@ resource "google_privateca_certificate" "default" {
}
x509_config {
ca_options {
non_ca = true
is_ca = false
}
key_usage {
Expand Down
8 changes: 3 additions & 5 deletions website/docs/r/privateca_certificate.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ resource "google_privateca_certificate" "default" {
locality = "mountain view"
province = "california"
street_address = "1600 amphitheatre parkway"
}
}
subject_alt_name {
email_addresses = ["email@example.com"]
ip_addresses = ["127.0.0.1"]
Expand All @@ -94,7 +94,6 @@ resource "google_privateca_certificate" "default" {
}
x509_config {
ca_options {
non_ca = true
is_ca = false
}
key_usage {
Expand Down Expand Up @@ -156,8 +155,8 @@ resource "google_privateca_certificate_template" "template" {
aia_ocsp_servers = ["string"]

ca_options {
is_ca = false
max_issuer_path_length = 6
is_ca = false
max_issuer_path_length = 6
}

key_usage {
Expand Down Expand Up @@ -353,7 +352,6 @@ resource "google_privateca_certificate" "default" {
}
x509_config {
ca_options {
non_ca = true
is_ca = false
}
key_usage {
Expand Down
1 change: 0 additions & 1 deletion website/docs/r/privateca_certificate_authority.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ resource "google_privateca_certificate_authority" "default" {
ca_options {
is_ca = true
# Force the sub CA to only issue leaf certs
zero_max_issuer_path_length = true
max_issuer_path_length = 0
}
key_usage {
Expand Down