Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced_options_config for compute_security_policy #4354

Conversation

modular-magician
Copy link
Collaborator

This adds support for advanced_options_config, supporting enabling JSON body parsing of payloads for Cloud Armor policies, as well as providing the option of enabling verbose logging.

Fixes hashicorp/terraform-provider-google#9939
Fixes hashicorp/terraform-provider-google#10497

https://cloud.google.com/compute/docs/reference/rest/v1/securityPolicies

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `advanced_options_config` to `google_compute_security_policy`

Derived from GoogleCloudPlatform/magic-modules#5851

…p#5851)

This adds support for advanced_options_config, supporting enabling JSON
body parsing of payloads for Cloud Armor policies, as well as well as
providing the option of enabling verbose logging.

Fixes hashicorp/terraform-provider-google#9939
Fixes hashicorp/terraform-provider-google#10497

https://cloud.google.com/compute/docs/reference/rest/v1/securityPolicies
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit ee93773 into hashicorp:main Jun 2, 2022
@modular-magician modular-magician deleted the downstream-pr-a88fc7f68d6782e3626b446af0574e49da214df6 branch November 16, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant