Add usage_period fields to billing_budget resource #4429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in the usage_period fields calendar_period and
custom_period
to thegoogle_billing_budget resource
.Fixes hashicorp/terraform-provider-google#10753
Fixes hashicorp/terraform-provider-google#9196
Also corrected some documentation errors with correct wording from public docs for creditTypes description. There are some additional documentation fixes needed, such as hashicorp/terraform-provider-google#9458
This PR is in draft as there are some outstanding issues I need assistance with:
budget_filter
block will not reset filters to default values. Conversely, if default values are set or computed forcalendar_period
, errors can occur when trying to change fromcalendar_period
tocustom_period
, as terraform won't unset thecalendar_period
property. Perhaps acustom_flatten
orcustom_expand
is needed but nothing I have tried has worked thus far.custom_period
Marking this PR as draft to hopefully get some feedback on the above items.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6099