Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for major version upgrade in cloud sql instance. #4606

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Adding support for major version upgrade in cloud sql instance. #4606

merged 1 commit into from
Aug 18, 2022

Conversation

modular-magician
Copy link
Collaborator

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: added support for major version upgrade to `google_sql_database_instance ` resource

Derived from GoogleCloudPlatform/magic-modules#6374

@modular-magician @melinath
Adding support for major version upgrade in cloud sql instance. (hash…
cb4da1c 
…icorp#6374)

* Adding support for major version upgrade in cloud sql instance.

* Resolving Lint errors

* Minor changes to improve readability

* Op redeclared in the file

* Update resource_sql_database_instance.go.erb

* Added test for the database version upgrade and added appropriate comments.

* Update mmv1/third_party/terraform/tests/resource_sql_database_instance_test.go.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 5fc475d into hashicorp:main Aug 18, 2022
@modular-magician modular-magician deleted the downstream-pr-92aa6c7ce86258c9aec8c531cc7e390614a4019a branch November 16, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician