Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add exp field to JWT if expires_in is set #4677

Conversation

modular-magician
Copy link
Collaborator

This commit adds the ability to add an exp field to the signed JWT. While Terraform has some time-related functions (e.g. timestamp and formatdate), there does not appear to be a Terraform-native way of generating a unix timestamp for the current time. Without this feature it would be impossible for a user to set exp to a meaningful value themselves.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_service_account_jwt: added `expires_in` attribute for generating `exp` claim.

Derived from GoogleCloudPlatform/magic-modules#6429

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit a364020 into hashicorp:main Sep 12, 2022
@modular-magician modular-magician deleted the downstream-pr-6806c8abe9721917a5e98ef88a7911482bc95a5b branch November 16, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant