Fix sql VCR test failure in replaying #4738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade
from failing in VCR replaying mode. The test takes about 30 mins to run in recording.Reason that
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade
failed in VCR replaying currently:The test is using a config
testGoogleSqlDatabaseInstance_basic2
which does have thename
set.If the name of the sql instance is not explicitly specified, Terraform will randomly generate one during creation, and therefore it creates randomness and makes the test failed in replaying.
The other place
testGoogleSqlDatabaseInstance_basic2
used is in testTestAccSqlDatabaseInstance_basicInferredName
. The test is intentionally set up to test if the name can be generated when it's not specified by users and it's skipped in VCR.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6625