Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sql VCR test failure in replaying #4738

Conversation

modular-magician
Copy link
Collaborator

This should prevent TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade from failing in VCR replaying mode. The test takes about 30 mins to run in recording.

Reason that TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade failed in VCR replaying currently:
The test is using a config testGoogleSqlDatabaseInstance_basic2 which does have the name set.
If the name of the sql instance is not explicitly specified, Terraform will randomly generate one during creation, and therefore it creates randomness and makes the test failed in replaying.

The other place testGoogleSqlDatabaseInstance_basic2 used is in test TestAccSqlDatabaseInstance_basicInferredName. The test is intentionally set up to test if the name can be generated when it's not specified by users and it's skipped in VCR.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#6625

* prevent TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade from failing in VCR replaying mode

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit d75d53a into hashicorp:main Sep 29, 2022
@modular-magician modular-magician deleted the downstream-pr-b7fd97e2ff301cb2ef1678bf91c8530e9f16991b branch November 16, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant