Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom GKE On-Prem error and operation #4762

Conversation

modular-magician
Copy link
Collaborator

The GKE OnPrem API outputs JSON error details in our long-running operations error_details. This isn't supported by mmv1.

This adds a custom implementation of the operation/error type by disabling the async file generation and using our own hand written one.

Our resources are only in the EAP provider today. If there's a way to include this there, let me know. Our API itself is public, so theres no concerns on our end with this being released.

See example: https://screenshot.googleplex.com/4GtiKbrTAQBMF2t

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#6647

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 1e66a57 into hashicorp:main Oct 7, 2022
@modular-magician modular-magician deleted the downstream-pr-ae795cd36448cd0c092fe007319eddac1d83d6a3 branch November 16, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant