Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for SQL Server Timezones #4774

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Adding support for SQL Server Timezones #4774

merged 1 commit into from
Oct 11, 2022

Conversation

modular-magician
Copy link
Collaborator

Fixes: hashicorp/terraform-provider-google#12705

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: added `time_zone` field in `google_sql_database_instance`

Derived from GoogleCloudPlatform/magic-modules#6635

@modular-magician @melinath
Adding support for SQL Server Timezones (hashicorp#6635)
4462c33 
* Adding timezone field to Terraform

* Change timezone name and add to tests

* adding timezone field

* Revert "adding timezone field"

This reverts commit 0b0dcf6bea0c613aad044f5014b3014fb6805850.

* renamed TimeZone field

* removing output log

* updated api version

* adding update

* Update mmv1/third_party/terraform/resources/resource_sql_database_instance.go.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* update storage version

* use storage 1.27

* fixed requirements

* changing into to pointer for storage_bucket.go

* remove update test and add ForceNew tag

Co-authored-by: Kevin Wang <kevinxuwang@google.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 374aab1 into hashicorp:main Oct 11, 2022
@modular-magician modular-magician deleted the downstream-pr-e3fed09de52ed6b6b1137d57d559c9326b00dbbe branch November 16, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support creation of SQL Server instances with Timezones using Google Cloud SQL
1 participant
@modular-magician