Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ability to create "non-custom" services #4789

Conversation

modular-magician
Copy link
Collaborator

Allow users to create various Service Monitoring services: App Engine, Cloud Run, etc.

hashicorp/terraform-provider-google#11935

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_monitoring_generic_service

Derived from GoogleCloudPlatform/magic-modules#6604

* Support ability to create "non-custom" services

Allow users to create various Service Monitoring services: App Engine,
Cloud Run, etc.

hashicorp/terraform-provider-google#11935

* Specify BasicService is immutable

* Responding to review comments.

* Add test; make service_id required

* labels still need input: true; remove encoder

* Correct typo

* Ignore service fields in SLO import test

* Correct test

* Make id_format and import_format the same

* Remove custom code

* Correct test typo

* service is actually input-only

* Add resource test

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 6e8c618 into hashicorp:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant