Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the test TestAccCloudBuildTrigger_migration #4931

Conversation

modular-magician
Copy link
Collaborator

Fixed hashicorp/terraform-provider-google#12909

We do not need to check the import state for a previous provider release.

Actually, there is a bug in sdk. They made the bug fix in 2.23.0. The test passed after upgrading sdk to 2.24.0. But sdk 2.24.0 introduced another bug, which caused more tests failing. Please check the PR GoogleCloudPlatform/magic-modules#6818.

For now we remove ImportStateVerify to fix the test from our side.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#6843

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 53ecade into hashicorp:main Nov 30, 2022
@modular-magician modular-magician deleted the downstream-pr-03a34081e76e16a8f0a6a5d27e8db6261d0bc673 branch November 16, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccCloudBuildTrigger_migration
1 participant