Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret Manager Topics #5149

Conversation

modular-magician
Copy link
Collaborator

Rotation requires topics, however topics do not require rotation.

➜  test_secret git:(main) ✗ terraform plan -out test.out

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # google_secret_manager_secret.testsecret will be created
  + resource "google_secret_manager_secret" "testsecret" {
      + create_time = (known after apply)
      + expire_time = (known after apply)
      + id          = (known after apply)
      + name        = (known after apply)
      + project     = "leons-playground"
      + secret_id   = "test-secret"

      + replication {
          + user_managed {
              + replicas {
                  + location = "australia-southeast1"
                }
            }
        }

      + topics {
          + name = "projects/leons-playground/topics/testqueue"
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

Saved the plan to: test.out

To perform exactly these actions, run the following command to apply:
    terraform apply "test.out"
➜  test_secret git:(main) ✗ terraform apply test.out 
google_secret_manager_secret.testsecret: Creating...
google_secret_manager_secret.testsecret: Creation complete after 2s [id=projects/leons-playground/secrets/test-secret]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

fixes hashicorp/terraform-provider-google#11413

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.
secretmanager: fixed incorrect required_with for topics in `google_secret_managed_secret`

Derived from GoogleCloudPlatform/magic-modules#7160

fixes hashicorp/terraform-provider-google#11413

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 62f8905 into hashicorp:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_secret_manager_secret: topics requires rotation block but should not
1 participant