Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ttl fields for feature store and entitytype #5178

Conversation

modular-magician
Copy link
Collaborator

  • Add the offlineStorageTtlDays field for google_vertex_ai_featurestore_entitytype
  • Add the onlineStorageTtlDays field for google_vertex_ai_featurestore

Both of these fields are currently beta-only

Fixes hashicorp/terraform-provider-google#13559

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

vertex_ai: added `online_storage_ttl_days` to `google_vertex_ai_featurestore` resource (beta)
vertex_ai: added `offline_storage_ttl_days` to `google_vertex_ai_featurestore_entitytype` resource (beta)

Derived from GoogleCloudPlatform/magic-modules#7164

* feat: add ttl fields for feature store and entitytype

* add example

* update example to use google-beta provider

* try different resource IDs for tests

* test: add min_version: beta to new test

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 9d02521 into hashicorp:main Feb 6, 2023
@modular-magician modular-magician deleted the downstream-pr-b93c97a551171f9b9579f49808a87cd1d673e2a9 branch November 16, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ttl parameters for Vertex FeatureStore and EntityType
1 participant