Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FirebaseApp sweepers #5209

Conversation

modular-magician
Copy link
Collaborator

These sweepers have been reporting that there are no sweepable resources, but there are resources accumulating and they have hit the limit. This makes a few changes to get the sweeper working as intended:

(One of the API specs for reference https://firebase.google.com/docs/reference/firebase-management/rest/v1beta1/projects.iosApps)

  • Fix the field used from the list response to apps
  • Fix the remove request to use POST
  • Fix the sweeper sweepable field to be displayName instead of name, because name is server-generated
  • Fix the displayNames used for FirebaseApp tests to include sweepable prefixes

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#7279

* Fix firebase app sweepers

* Fix test override quotes

* Fix delete urls in sweeper

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 71b0c4a into hashicorp:main Feb 14, 2023
@modular-magician modular-magician deleted the downstream-pr-e68b6d58488e82455fe1622cd482ca08e2a1f221 branch November 16, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant