update web app config datasource to plugin-framework #5403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert "revert plugin framework code (hashicorp#7287)" This reverts commit 06f9b2ee5fadc6c2537a94d207ae2092b57b3c0b. * changes to plugin-framework work for parity * add some provider tests fix other inconsistent errors with the sdk provider * update provider alias name * other changes * fix up base path test * update tests to use muxer * use beta provider when we need to for some of the provider tests * remove all the specific providers from the config * attempt to fix vcr tests * refactor the vcr configuration * capitalize provider factories * some test failure fixes * remove skip step if vcr * review comments * fixed pointer errors * move providerversion450 to be dependent on resource, revers diag pointers * reverse another pointer * update firebase apple app config datasource to plugin-framework * update with latest plugin-framework changes * Revert "revert plugin framework code (hashicorp#7287)" This reverts commit 06f9b2ee5fadc6c2537a94d207ae2092b57b3c0b. * changes to plugin-framework work for parity * add some provider tests fix other inconsistent errors with the sdk provider * update tests to use muxer * use beta provider when we need to for some of the provider tests * remove all the specific providers from the config * changes after merge * attempt to fix vcr tests * refactor the vcr configuration * capitalize provider factories * some test failure fixes * remove skip step if vcr * review comments * fixed pointer errors * move providerversion450 to be dependent on resource, revers diag pointers * update firebase apple app config datasource to plugin-framework * update web app config * update external provider version tests * rm non erb, bad merge maybe * update after a bad merge * add comments * review comments, applied them to dns data sources as well Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
deleted the
downstream-pr-88f6847f8d1acadacaf834d4fde4fa2439a2e197
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have this based off GoogleCloudPlatform/magic-modules#7266, updates the
google_firebase_web_app_configto use plugin-frameworkIf this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7501