Update apigee keystore resource names to be consistent #5454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoogleCloudPlatform/magic-modules#7518 was released in https://github.com/hashicorp/terraform-provider-google-beta/releases/tag/v4.60.0 adding
google_apigee_keystores_aliases_key_cert_file
. That resource is a fine-grained resource of https://cloud.google.com/apigee/docs/reference/apis/apigee/rest/v1/organizations.environments.keystores.aliases, a custom endpoint that supports multiple different kind of aliases.That resource probably should have been called
google_apigee_keystore_alias_key_cert_file
, orgoogle_apigee_env_keystore_alias_key_cert_file
based ongoogle_apigee_env_keystore
. See discussion in GoogleCloudPlatform/magic-modules#7472 (work on another of those FGRs that was started before that change, but took longer to finish).4.61.0
is set to include:*
google_apigee_env_keystore_alias_pkcs12
from GoogleCloudPlatform/magic-modules#7519*
google_apigee_env_keystore_alias_self_signed_cert
from GoogleCloudPlatform/magic-modules#7488However, these are subresources of the same resource. This PR corrects them to be self-consistent with the released resource (
google_apigee_keystores_aliases_key_cert_file
). Therefore the new resources will be:google_apigee_keystores_aliases_pkcs12
google_apigee_keystores_aliases_self_signed_cert
I'm not sure how to catch these situations faster- there were multiple PRs, multiple authors, multiple reviewers, and PRs took different lengths of time to go through review.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7665