Adding address groups firewall usage in the examples for Firewall and Network Firewall #5584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Network Firewall (hashicorp#7821) * creating the yaml file for address_group, and addinging in the docs overriding * added the address_groups and provided the update tests * fixed the address_groups type field, tests are passing * fix the address group and the examples to use the address_group in examples * adding the tests for firewall_policy_rule and updating the address_group resource * updating the variable naming usage * fix the usage examples in the global * fixing the variables for the tests, updating the address_group tests * fixing the direction, the tests with region are ok, need to fix the global * removing the updates in the resource compute firewall, requires improvement in address_group resource, fixed the tests for global * removing src_address_group from resource firewall test * refactoring address group operation to call the generic network security, updated the address group resource to accept the field parent, necessary to create project and org level, updated the tests that requires org level for firewall usage * fix the name of the file of address_group, removing default value for location and updating transport_tpg version * adding required for location field * fix the go vet error for the google-provider, updating file to .erb and adding tag to unless is ga Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
deleted the
downstream-pr-ce22d18271836f219b701a518da57c1d05020882
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the fields
destAddressGroupsandsrcAddressGroupsfor the resources documentation below:fixes: hashicorp/terraform-provider-google#14409
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7821