Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Pub/Sub Schema support for changing definitions via revisions #5750

Conversation

modular-magician
Copy link
Collaborator

Allows schema definition to be changed by committing schema revisions. Fixes hashicorp/terraform-provider-google#13997. This replaces GoogleCloudPlatform/magic-modules#7981. @SarahFrench and @melinath have the most context on this.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

pubsub: Allowed `definition` of `google_pubsub_schema` to change without deleting and recreating the resource by using schema revisions (https://cloud.google.com/pubsub/docs/schemas#commit-schema-revision)

Derived from GoogleCloudPlatform/magic-modules#8079

…ns (hashicorp#8079)

* Add support for Pub/Sub schema evolution

* Add example for Pub/Sub schema evolution

* Remove changes not to be made in a single PR

* Remove changes not to be made in a single PR

* Remove changes not to be made in a single PR

* Fix spacing

* Test update, import

* Reduce flakiness

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit cd617af into hashicorp:main Jun 8, 2023
@modular-magician modular-magician deleted the downstream-pr-739b446e1d58d11653238ad75cba90f1d7c9be97 branch November 16, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pubsub schema updates
1 participant