Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for local ssd recovery timeout field to instance and instance template. #5968

Conversation

modular-magician
Copy link
Collaborator

add support for local ssd recovery timeout field to instance and instance template.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `local_ssd_recovery_timeout` field to `google_compute_instance` resource (beta)
compute: added `local_ssd_recovery_timeout` field to `google_compute_instance_template` resource (beta)
compute: added `local_ssd_recovery_timeout` field to `google_compute_regional_instance_template` resource (beta)

Derived from GoogleCloudPlatform/magic-modules#8387

…ance template. (hashicorp#8387)

* Add local_ssd_recovery_timeout to Instance and Instance Template scheduling on Beta

* fix type on instances test

* fix update test issue

* add local_ssd_recovery_timeout field documentation to regional instance template

* update google.golange.org/api to v0.132.0

* add regional instance template test

* upgrade go versions

* fix test

* add tests for instance created from instance template or from machine image

* update version

* update version

* add missing test

* fix instance template test

* instance template

* fix instance from image test

* Update go.mod.erb

* Update go.sum

---------

Co-authored-by: Mohammed Gaballh <mkabdelrahman@google.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit c57ce7f into hashicorp:main Jul 28, 2023
@modular-magician modular-magician deleted the downstream-pr-07150310437aa9866816b836e0a95fe859b92884 branch November 16, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant