Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the new resource: google_dataflow_pipeline #6236

Conversation

modular-magician
Copy link
Collaborator

fix hashicorp/terraform-provider-google#12608

To merge this PR I have at least 3 problems.
I do not have a deep understanding of magic-modules and its associated systems, so I am looking for help from Reviewers.

  1. naming
    Originally, it would be very smart if the resource name could be google_dataflow_pipeline as in the original issue. However, dataflow_job already exists on the third_party side, and I could not use dataflow in yaml.
    Specifically, if I created a dataflow directory and created a Pipeline Object in it, make vet failed after outputting the provider.
  2. check the operation
    I was able to pass unittest locally as shown in the checkbox. However, I do not currently have the appropriate GCP project for verification and have not been able to verify that this provider works as we think it should. I would appreciate any good solutions if possible. I will continue to investigate this issue and may be able to implement it if a suitable IAM is found in a our GCP project. Or I may look into creating my own dedicated project.
  3. just projecting API parameters straight from GCP's API
    This PR just rewrites GCP's complex parameters directly into terraform. I don't consider myself particularly good at using a lot of NestedObjects; I did it this way because I didn't know how to implement yaml. If you have a good solution, please let me know.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_data_pipeline_pipeline`

Derived from GoogleCloudPlatform/magic-modules#7325

Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit f015383 into hashicorp:main Sep 8, 2023
@modular-magician modular-magician deleted the downstream-pr-20d170f1009f7b3c0227a52c0ea9e77d9de673d2 branch November 16, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Dataflow Pipelines
1 participant