Update to wrap generated import format regex in ^ and $ #6365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated regex * removing prefix fron vpntunnel text, updating billing info for allowing supplied uris wth a trailing * replacing importstateid, skipping import in generated sample * incorrect var Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
merged commit 80eb9f2
into
hashicorp:FEATURE-BRANCH-major-release-5.0.0
modular-magician
deleted the
downstream-pr-6cdbf4d42c5f254c57bdf57724e159a20f07e6c9
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hashicorp/terraform-provider-google#14731
Currently generated import_format regex in TPG is not wrapped in start of line and end of line tokens, which allows for certain edge case false positives in non-standard import formats supplied via override.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#8913