Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firebase Hosting Custom Domains #6409

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Firebase Hosting Custom Domains #6409

merged 1 commit into from
Sep 29, 2023

Conversation

modular-magician
Copy link
Collaborator

Add support for adding a custom domain with Firebase Hosting.
hashicorp/terraform-provider-google#12955

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_firebase_hosting_custom_domain`

Derived from GoogleCloudPlatform/magic-modules#8264

@modular-magician
Firebase Hosting Custom Domains (hashicorp#8264)
72f4665 
* Firebase Hosting Custom Domains provider

* Allow default values of cert_preference

* Make wait_dns_verification optionally false

* Remove redundant check_error fields

* Rename firebasehosting_customdomain_redirect to firebasehosting_customdomain_full

* Address review comments

* Spacing

* Move test to correct directory

* Fix package name

* Remove annotations and labels until we have a better example

* Fix cycle import

* migrate to envvar

* Better examples for the full resource

* Custom check_destroy

* Fix conflicting custom domain names between tests

* Set checkTime fields to output only

* Make hostState a string

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 8e6fa61 into hashicorp:main Sep 29, 2023
@modular-magician modular-magician deleted the downstream-pr-034412fae15533bb6855d7673c2959289599f84c branch November 16, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician