Refactor project_from_id acc test to use non-networking resources
#7079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#10165) [upstream:194527b84f9fa2d12d51d821ae7a5b2b0f894be5] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
merged commit 1100d9d
into
hashicorp:FEATURE-BRANCH-provider-functions
3 checks passed
modular-magician
deleted the
downstream-pr-194527b84f9fa2d12d51d821ae7a5b2b0f894be5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when I wrote the first iteration of these acceptance tests for provider-functions I used subnetworks as my go-to Compute resources that would return self_links but CIDR ranges causes trouble in the test projects. This PR replaces use of subnetworks with bigquery datasets as a resource that returns a self_link that contains project information
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10165