Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release provider-defined functions (#10288) #7153

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Mar 26, 2024

[upstream:c9cf14ddb3cabaec42953e86bdf2be122addb51e]

Release Note Template for Downstream PRs (will be copied)

provider: introduced support for provider-defined functions. This feature is in Terraform v1.8.0+.
provider: added provider-defined function `project_from_id` for retrieving the project id from a resource's self link or id
provider: added provider-defined functions `location_from_id`, `region_from_id`, and `zone_from_id` for retrieving the location/region/zone names from a resource's self link or id
provider: added provider-defined function `name_from_id` for retrieving the short-form name of a resource from its self link or id
provider: added provider-defined function `region_from_zone` for deriving a region from a zone's name

Derived from GoogleCloudPlatform/magic-modules#10288

Copy link

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@SarahFrench SarahFrench requested a review from shuyama1 March 26, 2024 22:57
@SarahFrench SarahFrench marked this pull request as ready for review March 26, 2024 22:57
@github-actions github-actions bot requested a review from rileykarson March 26, 2024 22:57
Copy link
Collaborator

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure the commit message has structured SHA data present, like hashicorp/terraform-provider-google@f426dc1 (Feel free to dismiss this once that's done)

@SarahFrench SarahFrench force-pushed the add-provider-functions branch from 2908c5d to 0912661 Compare March 26, 2024 23:12
@SarahFrench SarahFrench changed the title Generate provider from magic-modules commit c9cf14ddb3cabaec42953e86bdf2be122addb51e @SarahFrench Release provider-defined functions (#10288) Mar 26, 2024
@SarahFrench SarahFrench changed the title @SarahFrench Release provider-defined functions (#10288) Release provider-defined functions (#10288) Mar 26, 2024
@SarahFrench SarahFrench requested a review from melinath March 26, 2024 23:13
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[upstream:c9cf14ddb3cabaec42953e86bdf2be122addb51e]
@SarahFrench SarahFrench force-pushed the add-provider-functions branch from 0912661 to 8b02168 Compare March 26, 2024 23:26
@SarahFrench SarahFrench requested review from rileykarson and removed request for melinath March 26, 2024 23:28
@SarahFrench SarahFrench merged commit 8bc06db into main Mar 26, 2024
2 checks passed
@SarahFrench SarahFrench deleted the add-provider-functions branch June 20, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants