Add support for Access Context Manager product, AccessPolicy resource #96
Conversation
ghost
added
the
| log.Printf("[DEBUG] Updating AccessPolicy %q: %#v", d.Id(), obj) | ||
| updateMask := []string{} | ||
|
|
||
| if d.HasChange("parent") { |
There was a problem hiding this comment.
The comments at https://cloud.google.com/access-context-manager/docs/reference/rest/v1beta/accessPolicies make me think that parent can't be changed. Have you tried, by any chance?
There was a problem hiding this comment.
It's can't! It's input in MM, so it's ForceNew in the schema. This is an existing issue; see Filestore Instance networks as well.
I tried changing this by filtering input fields, and it's a little more nuanced than I'd hoped; afaik (based on testing like... 3 resources) it works as intended for resources that use PATCH, but it breaks some resources that use PUT. In the scope of this PR, I'd like to cite prior art since this won't have any effect on users, and I'll work out a separate PR to clean up the fields we send on Update as a followup
website/docs/r/accesscontextmanager_access_policy.html.markdown
Outdated
Show resolved
Hide resolved
modular-magician
force-pushed
the
codegen-pr-696
branch
from
6d24970 to
a6ec56a
Compare
/cc @rileykarson