made sign_in in google_identity_platform_config O+C (#9001) (#15907)

Signed-off-by: Modular Magician <magic-modules@google.com>
hashicorp · Sep 19, 2023 · 05b68ef · 05b68ef
1 parent 36d9c1a
commit 05b68ef
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/.changelog/9001.txt b/.changelog/9001.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+identityplayform: fixed a potential perma-diff for `sign_in` in `google_identity_platform_config` resource
+```
diff --git a/google/services/identityplatform/resource_identity_platform_config.go b/google/services/identityplatform/resource_identity_platform_config.go
@@ -157,6 +157,7 @@ func ResourceIdentityPlatformConfig() *schema.Resource {
 			},
 			"sign_in": {
 				Type:        schema.TypeList,
+				Computed:    true,
 				Optional:    true,
 				Description: `Configuration related to local sign in methods.`,
 				MaxItems:    1,

diff --git a/google/services/identityplatform/resource_identity_platform_config_generated_test.go b/google/services/identityplatform/resource_identity_platform_config_generated_test.go
@@ -119,7 +119,6 @@ resource "google_identity_platform_config" "default" {
 }
 
 func TestAccIdentityPlatformConfig_identityPlatformConfigMinimalExample(t *testing.T) {
-	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	context := map[string]interface{}{
@@ -164,6 +163,10 @@ resource "google_project_service" "identitytoolkit" {
 
 resource "google_identity_platform_config" "default" {
   project = google_project.default.project_id
+  
+  depends_on = [
+    google_project_service.identitytoolkit
+  ]
 }
 `, context)
 }