Skip to content

Commit

Permalink
enhancement: Adjust kms rotation period accoring documentation (#9792) (
Browse files Browse the repository at this point in the history
#16971)

* Adjust KMS key rotation to 90 days

* Adjust missing KMS key rotation to 90 days

* Avoid impact on .go and .go.erb files

* Remove extra 0
[upstream:f7232c1f4011a86749d656f575e08431c0e3b52c]

Signed-off-by: Modular Magician <magic-modules@google.com>
  • Loading branch information
modular-magician authored Jan 11, 2024
1 parent 8680f94 commit 1bee237
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 7 deletions.
2 changes: 2 additions & 0 deletions .changelog/9792.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
```release-note:none
```
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ resource "google_kms_key_ring" "keyring" {
resource "google_kms_crypto_key" "crypto_key" {
name = "tf-test-crypto-name%{random_suffix}"
key_ring = google_kms_key_ring.keyring.id
# rotation_period = "100000s"
# rotation_period = "7776000s"
}
resource "google_netapp_kmsconfig" "kmsConfig" {
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/google_kms_crypto_key_iam.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ resource "google_kms_key_ring" "keyring" {
resource "google_kms_crypto_key" "key" {
name = "crypto-key-example"
key_ring = google_kms_key_ring.keyring.id
rotation_period = "100000s"
rotation_period = "7776000s"
lifecycle {
prevent_destroy = true
}
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/kms_crypto_key.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ resource "google_kms_key_ring" "keyring" {
resource "google_kms_crypto_key" "example-key" {
name = "crypto-key-example"
key_ring = google_kms_key_ring.keyring.id
rotation_period = "100000s"
rotation_period = "7776000s"
lifecycle {
prevent_destroy = true
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/kms_crypto_key_version.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ resource "google_kms_key_ring" "keyring" {
resource "google_kms_crypto_key" "cryptokey" {
name = "crypto-key-example"
key_ring = google_kms_key_ring.keyring.id
rotation_period = "100000s"
rotation_period = "7776000s"
}
resource "google_kms_crypto_key_version" "example-key" {
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/kms_secret_ciphertext.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ resource "google_kms_key_ring" "keyring" {
resource "google_kms_crypto_key" "cryptokey" {
name = "crypto-key-example"
key_ring = google_kms_key_ring.keyring.id
rotation_period = "100000s"
rotation_period = "7776000s"
lifecycle {
prevent_destroy = true
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/logging_project_bucket_config.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ resource "google_kms_key_ring" "keyring" {
resource "google_kms_crypto_key" "key" {
name = "crypto-key-example"
key_ring = google_kms_key_ring.keyring.id
rotation_period = "100000s"
rotation_period = "7776000s"
}
resource "google_kms_crypto_key_iam_binding" "crypto_key_binding" {
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/netapp_kmsconfig.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ resource "google_kms_key_ring" "keyring" {
resource "google_kms_crypto_key" "crypto_key" {
name = "crypto-name"
key_ring = google_kms_key_ring.keyring.id
# rotation_period = "100000s"
# rotation_period = "7776000s"
}
resource "google_netapp_kmsconfig" "kmsConfig" {
Expand Down

0 comments on commit 1bee237

Please sign in to comment.