Skip to content

Commit

Permalink
Handled async operation of Folder deletion (#7011) (#13377)
Browse files Browse the repository at this point in the history
Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
  • Loading branch information
modular-magician authored Jan 3, 2023
1 parent ea5767b commit 21e9ba4
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .changelog/7011.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
cloudplatform: handled async operation for `google_folder` deletion
```
15 changes: 14 additions & 1 deletion google/resource_google_folder.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,13 +215,26 @@ func resourceGoogleFolderDelete(d *schema.ResourceData, meta interface{}) error
}
displayName := d.Get("display_name").(string)

var op *resourceManagerV3.Operation
err = retryTimeDuration(func() error {
_, reqErr := config.NewResourceManagerV3Client(userAgent).Folders.Delete(d.Id()).Do()
var reqErr error
op, reqErr = config.NewResourceManagerV3Client(userAgent).Folders.Delete(d.Id()).Do()
return reqErr
}, d.Timeout(schema.TimeoutDelete))
if err != nil {
return fmt.Errorf("Error deleting folder '%s': %s", displayName, err)
}

opAsMap, err := ConvertToMap(op)
if err != nil {
return err
}

err = resourceManagerOperationWaitTime(config, opAsMap, "deleting folder", userAgent, d.Timeout(schema.TimeoutDelete))
if err != nil {
return fmt.Errorf("Error deleting folder '%s': %s", displayName, err)
}

return nil
}

Expand Down

0 comments on commit 21e9ba4

Please sign in to comment.