Skip to content

Commit

Permalink
Make cloud composer environment image version updateable.
Browse files Browse the repository at this point in the history
Signed-off-by: Modular Magician <magic-modules@google.com>
  • Loading branch information
jmcarp authored and modular-magician committed May 28, 2019
1 parent a28fcec commit 52f65aa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 0 additions & 1 deletion google/resource_composer_environment.go
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,6 @@ func resourceComposerEnvironmentUpdate(d *schema.ResourceData, meta interface{})
}

if d.HasChange("config.0.software_config.0.airflow_config_overrides") {

patchObj := &composer.Environment{
Config: &composer.EnvironmentConfig{
SoftwareConfig: &composer.SoftwareConfig{
Expand Down
6 changes: 4 additions & 2 deletions google/resource_composer_environment_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ func testAccComposerEnvironmentDestroy(s *terraform.State) error {
func testAccComposerEnvironment_basic(name string) string {
return fmt.Sprintf(`
resource "google_composer_environment" "test" {
name = "%s"
region = "us-central1"
name = "%s"
region = "us-central1"
}
`, name)
}
Expand All @@ -244,6 +244,8 @@ resource "google_composer_environment" "test" {
node_count = 4
software_config {
image_version = "composer-1.7.0-airflow-1.10.2"
airflow_config_overrides = {
core-load_example = "True"
}
Expand Down

0 comments on commit 52f65aa

Please sign in to comment.