Skip to content

Commit

Permalink
[#13369] Format google_compute_network_firewall_policy_rule doc examp…
Browse files Browse the repository at this point in the history 
…les (#7067) (#13371)

Co-authored-by: Luca Prete <lucaprete@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
Co-authored-by: Luca Prete <lucaprete@google.com>
  • Loading branch information
@modular-magician
modular-magician and Luca Prete authored Jan 3, 2023
1 parent 22e1229 commit 5d1c597
Show file tree
Hide file tree
Showing 5 changed files with 206 additions and 177 deletions.
3 changes: 3 additions & 0 deletions .changelog/7067.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:none
compute: format `google_compute_network_firewall_policy_rule` doc examples
```
122 changes: 66 additions & 56 deletions google/resource_compute_network_firewall_policy_rule_generated_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,49 +64,53 @@ func TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten(t *testing.T) {
func testAccComputeNetworkFirewallPolicyRule_GlobalHandWritten(context map[string]interface{}) string {
return Nprintf(`
resource "google_compute_network_firewall_policy" "basic_network_firewall_policy" {
name = "tf-test-policy%{random_suffix}"
project = "%{project_name}"
name = "tf-test-policy%{random_suffix}"
description = "Sample global network firewall policy"
project = "%{project_name}"
}
resource "google_compute_network_firewall_policy_rule" "primary" {
firewall_policy = google_compute_network_firewall_policy.basic_network_firewall_policy.name
action = "allow"
direction = "INGRESS"
priority = 1000
rule_name = "test-rule"
description = "This is a simple rule description"
match {
src_secure_tags {
name = "tagValues/${google_tags_tag_value.basic_value.name}"
}
src_ip_ranges = ["10.100.0.1/32"]
layer4_configs {
ip_protocol = "all"
}
}
target_service_accounts = ["%{service_acct}"]
enable_logging = true
disabled = false
action = "allow"
description = "This is a simple rule description"
direction = "INGRESS"
disabled = false
enable_logging = true
firewall_policy = google_compute_network_firewall_policy.basic_network_firewall_policy.name
priority = 1000
rule_name = "test-rule"
target_service_accounts = ["%{service_acct}"]
match {
src_ip_ranges = ["10.100.0.1/32"]
src_secure_tags {
name = "tagValues/${google_tags_tag_value.basic_value.name}"
}
layer4_configs {
ip_protocol = "all"
}
}
}
resource "google_compute_network" "basic_network" {
name = "tf-test-network%{random_suffix}"
}
resource "google_tags_tag_key" "basic_key" {
parent = "organizations/%{org_id}"
short_name = "tf-test-tagkey%{random_suffix}"
purpose = "GCE_FIREWALL"
description = "For keyname resources."
parent = "organizations/%{org_id}"
purpose = "GCE_FIREWALL"
short_name = "tf-test-tagkey%{random_suffix}"
purpose_data = {
network= "%{project_name}/${google_compute_network.basic_network.name}"
network = "%{project_name}/${google_compute_network.basic_network.name}"
}
description = "For keyname resources."
}
resource "google_tags_tag_value" "basic_value" {
parent = "tagKeys/${google_tags_tag_key.basic_key.name}"
short_name = "tf-test-tagvalue%{random_suffix}"
description = "For valuename resources."
description = "For valuename resources."
parent = "tagKeys/${google_tags_tag_key.basic_key.name}"
short_name = "tf-test-tagvalue%{random_suffix}"
}
`, context)
Expand All @@ -115,49 +119,55 @@ resource "google_tags_tag_value" "basic_value" {
func testAccComputeNetworkFirewallPolicyRule_GlobalHandWrittenUpdate0(context map[string]interface{}) string {
return Nprintf(`
resource "google_compute_network_firewall_policy" "basic_network_firewall_policy" {
name = "tf-test-policy%{random_suffix}"
project = "%{project_name}"
name = "tf-test-policy%{random_suffix}"
description = "Sample global network firewall policy"
project = "%{project_name}"
}
resource "google_compute_network_firewall_policy_rule" "primary" {
firewall_policy = google_compute_network_firewall_policy.basic_network_firewall_policy.name
action = "deny"
direction = "EGRESS"
priority = 1000
rule_name = "updated-test-rule"
description = "This is an updated rule description"
match {
layer4_configs {
ip_protocol = "tcp"
ports = ["123"]
}
dest_ip_ranges = ["0.0.0.0/0"]
}
action = "deny"
description = "This is an updated rule description"
direction = "EGRESS"
disabled = true
enable_logging = false
firewall_policy = google_compute_network_firewall_policy.basic_network_firewall_policy.name
priority = 1000
rule_name = "updated-test-rule"
match {
dest_ip_ranges = ["0.0.0.0/0"]
layer4_configs {
ip_protocol = "tcp"
ports = ["123"]
}
}
target_secure_tags {
name = "tagValues/${google_tags_tag_value.basic_value.name}"
}
enable_logging = false
disabled = true
name = "tagValues/${google_tags_tag_value.basic_value.name}"
}
}
resource "google_compute_network" "basic_network" {
name = "tf-test-network%{random_suffix}"
}
resource "google_tags_tag_key" "basic_key" {
parent = "organizations/%{org_id}"
short_name = "tf-test-tagkey%{random_suffix}"
purpose = "GCE_FIREWALL"
description = "For keyname resources."
parent = "organizations/%{org_id}"
purpose = "GCE_FIREWALL"
short_name = "tf-test-tagkey%{random_suffix}"
purpose_data = {
network= "%{project_name}/${google_compute_network.basic_network.name}"
network = "%{project_name}/${google_compute_network.basic_network.name}"
}
description = "For keyname resources."
}
resource "google_tags_tag_value" "basic_value" {
parent = "tagKeys/${google_tags_tag_key.basic_key.name}"
short_name = "tf-test-tagvalue%{random_suffix}"
description = "For valuename resources."
description = "For valuename resources."
parent = "tagKeys/${google_tags_tag_key.basic_key.name}"
short_name = "tf-test-tagvalue%{random_suffix}"
}
`, context)
Expand Down
130 changes: 69 additions & 61 deletions google/resource_compute_region_network_firewall_policy_rule_generated_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,52 +65,56 @@ func TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten(t *testin
func testAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten(context map[string]interface{}) string {
return Nprintf(`
resource "google_compute_region_network_firewall_policy" "basic_regional_network_firewall_policy" {
name = "tf-test-policy%{random_suffix}"
project = "%{project_name}"
name = "tf-test-policy%{random_suffix}"
description = "Sample regional network firewall policy"
region = "%{region}"
project = "%{project_name}"
region = "%{region}"
}
resource "google_compute_region_network_firewall_policy_rule" "primary" {
firewall_policy = google_compute_region_network_firewall_policy.basic_regional_network_firewall_policy.name
action = "allow"
direction = "INGRESS"
priority = 1000
rule_name = "test-rule"
description = "This is a simple rule description"
match {
src_secure_tags {
name = "tagValues/${google_tags_tag_value.basic_value.name}"
}
src_ip_ranges = ["10.100.0.1/32"]
layer4_configs {
ip_protocol = "all"
}
}
target_service_accounts = ["%{service_acct}"]
region = "%{region}"
enable_logging = true
disabled = false
action = "allow"
description = "This is a simple rule description"
direction = "INGRESS"
disabled = false
enable_logging = true
firewall_policy = google_compute_region_network_firewall_policy.basic_regional_network_firewall_policy.name
priority = 1000
region = "%{region}"
rule_name = "test-rule"
target_service_accounts = ["%{service_acct}"]
match {
src_ip_ranges = ["10.100.0.1/32"]
layer4_configs {
ip_protocol = "all"
}
src_secure_tags {
name = "tagValues/${google_tags_tag_value.basic_value.name}"
}
}
}
resource "google_compute_network" "basic_network" {
name = "tf-test-network%{random_suffix}"
}
resource "google_tags_tag_key" "basic_key" {
parent = "organizations/%{org_id}"
short_name = "tf-test-tagkey%{random_suffix}"
purpose = "GCE_FIREWALL"
description = "For keyname resources."
parent = "organizations/%{org_id}"
purpose = "GCE_FIREWALL"
short_name = "tf-test-tagkey%{random_suffix}"
purpose_data = {
network= "%{project_name}/${google_compute_network.basic_network.name}"
network = "%{project_name}/${google_compute_network.basic_network.name}"
}
description = "For keyname resources."
}
resource "google_tags_tag_value" "basic_value" {
parent = "tagKeys/${google_tags_tag_key.basic_key.name}"
short_name = "tf-test-tagvalue%{random_suffix}"
description = "For valuename resources."
description = "For valuename resources."
parent = "tagKeys/${google_tags_tag_key.basic_key.name}"
short_name = "tf-test-tagvalue%{random_suffix}"
}
`, context)
Expand All @@ -119,52 +123,56 @@ resource "google_tags_tag_value" "basic_value" {
func testAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWrittenUpdate0(context map[string]interface{}) string {
return Nprintf(`
resource "google_compute_region_network_firewall_policy" "basic_regional_network_firewall_policy" {
name = "tf-test-policy%{random_suffix}"
project = "%{project_name}"
name = "tf-test-policy%{random_suffix}"
description = "Sample regional network firewall policy"
region = "%{region}"
project = "%{project_name}"
region = "%{region}"
}
resource "google_compute_region_network_firewall_policy_rule" "primary" {
firewall_policy = google_compute_region_network_firewall_policy.basic_regional_network_firewall_policy.name
action = "deny"
direction = "EGRESS"
priority = 1000
rule_name = "updated-test-rule"
description = "This is an updated rule description"
match {
layer4_configs {
ip_protocol = "tcp"
ports = ["123"]
}
dest_ip_ranges = ["0.0.0.0/0"]
}
action = "deny"
description = "This is an updated rule description"
direction = "EGRESS"
disabled = true
enable_logging = false
firewall_policy = google_compute_region_network_firewall_policy.basic_regional_network_firewall_policy.name
priority = 1000
region = "%{region}"
rule_name = "updated-test-rule"
match {
dest_ip_ranges = ["0.0.0.0/0"]
layer4_configs {
ip_protocol = "tcp"
ports = ["123"]
}
}
target_secure_tags {
name = "tagValues/${google_tags_tag_value.basic_value.name}"
}
region = "%{region}"
enable_logging = false
disabled = true
name = "tagValues/${google_tags_tag_value.basic_value.name}"
}
}
resource "google_compute_network" "basic_network" {
name = "tf-test-network%{random_suffix}"
}
resource "google_tags_tag_key" "basic_key" {
parent = "organizations/%{org_id}"
short_name = "tf-test-tagkey%{random_suffix}"
purpose = "GCE_FIREWALL"
description = "For keyname resources."
parent = "organizations/%{org_id}"
purpose = "GCE_FIREWALL"
short_name = "tf-test-tagkey%{random_suffix}"
purpose_data = {
network= "%{project_name}/${google_compute_network.basic_network.name}"
network = "%{project_name}/${google_compute_network.basic_network.name}"
}
description = "For keyname resources."
}
resource "google_tags_tag_value" "basic_value" {
parent = "tagKeys/${google_tags_tag_key.basic_key.name}"
short_name = "tf-test-tagvalue%{random_suffix}"
description = "For valuename resources."
description = "For valuename resources."
parent = "tagKeys/${google_tags_tag_key.basic_key.name}"
short_name = "tf-test-tagvalue%{random_suffix}"
}
`, context)
Expand Down
Loading

0 comments on commit 5d1c597

Please sign in to comment.