Skip to content

Commit

Permalink
Allowing GlobalAddress.address to be settable (#2618)
Browse files Browse the repository at this point in the history
<!-- This change is generated by MagicModules. -->
/cc @chrisst
  • Loading branch information
modular-magician authored and chrisst committed Dec 11, 2018
1 parent 18cf985 commit 6762cec
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 7 deletions.
20 changes: 16 additions & 4 deletions google/resource_compute_global_address.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ func resourceComputeGlobalAddress() *schema.Resource {
Required: true,
ForceNew: true,
},
"address": {
Type: schema.TypeString,
Computed: true,
Optional: true,
ForceNew: true,
},
"address_type": {
Type: schema.TypeString,
Optional: true,
Expand All @@ -66,10 +72,6 @@ func resourceComputeGlobalAddress() *schema.Resource {
ValidateFunc: validation.StringInSlice([]string{"IPV4", "IPV6", ""}, false),
DiffSuppressFunc: emptyOrDefaultStringSuppress("IPV4"),
},
"address": {
Type: schema.TypeString,
Computed: true,
},
"creation_timestamp": {
Type: schema.TypeString,
Computed: true,
Expand All @@ -92,6 +94,12 @@ func resourceComputeGlobalAddressCreate(d *schema.ResourceData, meta interface{}
config := meta.(*Config)

obj := make(map[string]interface{})
addressProp, err := expandComputeGlobalAddressAddress(d.Get("address"), d, config)
if err != nil {
return err
} else if v, ok := d.GetOkExists("address"); !isEmptyValue(reflect.ValueOf(addressProp)) && (ok || !reflect.DeepEqual(v, addressProp)) {
obj["address"] = addressProp
}
descriptionProp, err := expandComputeGlobalAddressDescription(d.Get("description"), d, config)
if err != nil {
return err
Expand Down Expand Up @@ -281,6 +289,10 @@ func flattenComputeGlobalAddressAddressType(v interface{}, d *schema.ResourceDat
return v
}

func expandComputeGlobalAddressAddress(v interface{}, d *schema.ResourceData, config *Config) (interface{}, error) {
return v, nil
}

func expandComputeGlobalAddressDescription(v interface{}, d *schema.ResourceData, config *Config) (interface{}, error) {
return v, nil
}
Expand Down
7 changes: 4 additions & 3 deletions website/docs/r/compute_global_address.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ The following arguments are supported:
- - -


* `address` -
(Optional)
The static external IP address represented by this resource.

* `description` -
(Optional)
An optional description of this resource.
Expand All @@ -88,9 +92,6 @@ The following arguments are supported:
In addition to the arguments listed above, the following computed attributes are exported:


* `address` -
The static external IP address represented by this resource.

* `creation_timestamp` -
Creation timestamp in RFC3339 text format.
* `self_link` - The URI of the created resource.
Expand Down

0 comments on commit 6762cec

Please sign in to comment.