Skip to content

Commit

Permalink
Add Firebase AppleApp Data Source (#6876) (#13239)
Browse files Browse the repository at this point in the history
* Update api.yaml

* Update api.yaml

* Update api.yaml

* Update api.yaml

* Update terraform.yaml

* Create firebase_apple_app_basic.tf.erb

* Responding to tylerg-dev's comments

* Fixing the failing TestAccFirebaseAppleApp_firebaseAppleAppBasicExample test

* Add a handwritten sweeper to hard-delete the AppleApp

* Fix typo in update_mask

* Fix var name in test

* Add delete request body

* Change appId to app_id in the sweeper delete url

* Use custom_delete for deleting the AppleApp resource

* Update api.yaml

* Remove the repeated block in terraform.api

* Add a 5 sec in the post_delete template

* Move the 5 sec delay to the custom delete code

* Add "Optional" to the deletion_policy description.

* Address melinath@ comments

* Add a manual update test

* Remove unnecessary randomness. Also, move attributes to the vars section so they show up in docs.

* Update mmv1/products/firebase/terraform.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/firebase/terraform.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/firebase/terraform.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_update_test.go.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_update_test.go.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_update_test.go.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Adding back the test_vars_overrides.

* Add a Datasource for Firebase AppleApp

* Fix lint warnings

* Add documentations and fix the test

* Update the test providers.

* Remove the providers from the AppleApp datasource tests

* Add GA tags to the data source test and rename it to .go.erb

* Fix tabs in Datasource map.

* Add randomness to bundle_id to avoid collision.

* Responding to roaks3's comments

* Remove ws from data_source_google_firebase_web_app.go.erb

* Remove unneeded whitespaces from provider.go.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
  • Loading branch information
modular-magician and melinath authored Dec 14, 2022
1 parent c8f3ec8 commit 7bbe743
Show file tree
Hide file tree
Showing 5 changed files with 63 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .changelog/6876.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:new-datasource
`google_firebase_apple_app`
```
1 change: 1 addition & 0 deletions google/data_source_google_firebase_apple_app.go
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
package google
1 change: 1 addition & 0 deletions google/data_source_google_firebase_apple_app_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
package google
2 changes: 1 addition & 1 deletion website/docs/d/firebase_android_app.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ The following arguments are supported:

* `app_id` -
(Required)
The app_ip of name of the Firebase androidApp.
The app_id of name of the Firebase androidApp.


- - -
Expand Down
57 changes: 57 additions & 0 deletions website/docs/d/firebase_apple_app.html.markdown
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
---
subcategory: "Firebase"
page_title: "Google: google_firebase_apple_app"
description: |-
A Google Cloud Firebase Apple application instance
---

# google\_firebase\_apple\_app

A Google Cloud Firebase Apple application instance

~> **Warning:** This resource is in beta, and should be used with the terraform-provider-google-beta provider.
See [Provider Versions](https://terraform.io/docs/providers/google/guides/provider_versions.html) for more details on beta resources.


## Argument Reference

The following arguments are supported:


* `app_id` -
(Required)
The app_id of name of the Firebase iosApp.


- - -


* `project` - (Optional) The ID of the project in which the resource belongs.
If it is not provided, the provider project is used.


## Attributes Reference

In addition to the arguments listed above, the following computed attributes are exported:

* `id` - an identifier for the resource with format `{{name}}`

* `name` -
The fully qualified resource name of the App, for example:
projects/projectId/iosApps/appId

* `app_id` -
Immutable. The globally unique, Firebase-assigned identifier of the App.
This identifier should be treated as an opaque token, as the data format is not specified.

* `display_name` -
The user-assigned display name of the App.

* `bundle_id` -
The canonical bundle ID of the Apple app as it would appear in the Apple AppStore.

* `app_store_id` -
The automatically generated Apple ID assigned to the Apple app by Apple in the Apple App Store.

* `team_id` -
The Apple Developer Team ID associated with the App in the App Store.

0 comments on commit 7bbe743

Please sign in to comment.