Skip to content

Commit

Permalink
expand valid values for bigquery dataset (#7141) (#13520)
Browse files Browse the repository at this point in the history
closes #13484

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
  • Loading branch information
modular-magician committed Jan 18, 2023
1 parent b9f6caa commit 9f3cbac
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .changelog/7141.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
bigquery: fixed bug where valid iam member values for bigquery were prevented from actuation by validation
```
2 changes: 1 addition & 1 deletion google/resource_iam_member.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func validateIAMMember(i interface{}, k string) ([]string, []error) {
return nil, []error{fmt.Errorf("invalid value for %s (Terraform does not support IAM members for deleted principals)", k)}
}

if matched, err := regexp.MatchString("(.+:.+|allUsers|allAuthenticatedUsers)", v); err != nil {
if matched, err := regexp.MatchString("(.+:.+|projectOwners|projectReaders|projectWriters|allUsers|allAuthenticatedUsers)", v); err != nil {
return nil, []error{fmt.Errorf("error validating %s: %v", k, err)}
} else if !matched {
return nil, []error{fmt.Errorf("invalid value for %s (IAM members must have one of the values outlined here: https://cloud.google.com/billing/docs/reference/rest/v1/Policy#Binding)", k)}
Expand Down

0 comments on commit 9f3cbac

Please sign in to comment.