Made billing budget filter labels updatable (#5545) (#10767)

Signed-off-by: Modular Magician <magic-modules@google.com>
hashicorp · Dec 16, 2021 · a54fad2 · a54fad2
1 parent 4539e26
commit a54fad2
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/.changelog/5545.txt b/.changelog/5545.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+billingbudget: fixed a bug where `google_billing_budget.budget_filter.labels` was not updating.
+```
diff --git a/google/resource_billing_budget.go b/google/resource_billing_budget.go
@@ -468,7 +468,8 @@ func resourceBillingBudgetUpdate(d *schema.ResourceData, meta interface{}) error
 	}
 
 	if d.HasChange("budget_filter") {
-		updateMask = append(updateMask, "budgetFilter.projects")
+		updateMask = append(updateMask, "budgetFilter.projects",
+			"budgetFilter.labels")
 	}
 
 	if d.HasChange("amount") {

diff --git a/google/resource_billing_budget_test.go b/google/resource_billing_budget_test.go
@@ -128,6 +128,9 @@ resource "google_billing_budget" "budget" {
 
   budget_filter {
     projects = ["projects/${data.google_project.project.number}"]
+    labels  = {
+      label = "bar"
+    }
   }
 
   amount {
@@ -173,6 +176,7 @@ resource "google_billing_budget" "budget" {
 
   budget_filter {
     projects = []
+    labels = {}
   }
 
   amount {
@@ -218,6 +222,9 @@ resource "google_billing_budget" "budget" {
 
   budget_filter {
     projects = []
+    labels  = {
+      label1 = "bar2"
+    }
   }
 
   amount {