Skip to content

Commit

Permalink
WIP: Add deprecation message for generated beta fields.
Browse files Browse the repository at this point in the history
  • Loading branch information
danawillow authored and modular-magician committed Oct 3, 2018
1 parent 1f76d44 commit b6f7a24
Show file tree
Hide file tree
Showing 28 changed files with 89 additions and 48 deletions.
3 changes: 3 additions & 0 deletions google/resource_binaryauthorization_attestor.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ func resourceBinaryAuthorizationAttestor() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceBinaryAuthorizationAttestorImport,
},
DeprecationMessage: `This resource is in beta and will be removed from this provider.
Use the BinaryAuthorizationAttestor resource in terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta resources.`,

Schema: map[string]*schema.Schema{
"attestation_authority_note": {
Expand Down
3 changes: 3 additions & 0 deletions google/resource_binaryauthorization_policy.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ func resourceBinaryAuthorizationPolicy() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceBinaryAuthorizationPolicyImport,
},
DeprecationMessage: `This resource is in beta and will be removed from this provider.
Use the BinaryAuthorizationPolicy resource in terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta resources.`,

Schema: map[string]*schema.Schema{
"default_admission_rule": {
Expand Down
20 changes: 14 additions & 6 deletions google/resource_compute_address.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ func resourceComputeAddress() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeAddressImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down Expand Up @@ -70,13 +69,19 @@ func resourceComputeAddress() *schema.Resource {
"labels": {
Type: schema.TypeMap,
Optional: true,
Elem: &schema.Schema{Type: schema.TypeString},
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
Elem: &schema.Schema{Type: schema.TypeString},
},
"network_tier": {
Type: schema.TypeString,
Computed: true,
Optional: true,
ForceNew: true,
Type: schema.TypeString,
Computed: true,
Optional: true,
ForceNew: true,
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
ValidateFunc: validation.StringInSlice([]string{"PREMIUM", "STANDARD", ""}, false),
},
"region": {
Expand All @@ -100,6 +105,9 @@ func resourceComputeAddress() *schema.Resource {
"label_fingerprint": {
Type: schema.TypeString,
Computed: true,
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
},
"users": {
Type: schema.TypeList,
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_autoscaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ func resourceComputeAutoscaler() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeAutoscalerImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_backend_bucket.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ func resourceComputeBackendBucket() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeBackendBucketImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_disk.go
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,6 @@ func resourceComputeDisk() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeDiskImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(300 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down
7 changes: 6 additions & 1 deletion google/resource_compute_firewall.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ func resourceComputeFirewall() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeFirewallImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down Expand Up @@ -144,10 +143,16 @@ func resourceComputeFirewall() *schema.Resource {
"disabled": {
Type: schema.TypeBool,
Optional: true,
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
},
"enable_logging": {
Type: schema.TypeBool,
Optional: true,
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
},
"priority": {
Type: schema.TypeInt,
Expand Down
29 changes: 20 additions & 9 deletions google/resource_compute_forwarding_rule.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ func resourceComputeForwardingRule() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeForwardingRuleImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down Expand Up @@ -83,7 +82,10 @@ func resourceComputeForwardingRule() *schema.Resource {
"labels": {
Type: schema.TypeMap,
Optional: true,
Elem: &schema.Schema{Type: schema.TypeString},
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
Elem: &schema.Schema{Type: schema.TypeString},
},
"load_balancing_scheme": {
Type: schema.TypeString,
Expand All @@ -100,10 +102,13 @@ func resourceComputeForwardingRule() *schema.Resource {
DiffSuppressFunc: compareSelfLinkOrResourceName,
},
"network_tier": {
Type: schema.TypeString,
Computed: true,
Optional: true,
ForceNew: true,
Type: schema.TypeString,
Computed: true,
Optional: true,
ForceNew: true,
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
ValidateFunc: validation.StringInSlice([]string{"PREMIUM", "STANDARD", ""}, false),
},
"port_range": {
Expand All @@ -130,9 +135,12 @@ func resourceComputeForwardingRule() *schema.Resource {
DiffSuppressFunc: compareSelfLinkOrResourceName,
},
"service_label": {
Type: schema.TypeString,
Optional: true,
ForceNew: true,
Type: schema.TypeString,
Optional: true,
ForceNew: true,
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
ValidateFunc: validateGCPName,
},
"subnetwork": {
Expand All @@ -158,6 +166,9 @@ func resourceComputeForwardingRule() *schema.Resource {
"service_name": {
Type: schema.TypeString,
Computed: true,
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
},
"project": {
Type: schema.TypeString,
Expand Down
36 changes: 25 additions & 11 deletions google/resource_compute_global_address.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ func resourceComputeGlobalAddress() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeGlobalAddressImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand All @@ -50,9 +49,12 @@ func resourceComputeGlobalAddress() *schema.Resource {
ForceNew: true,
},
"address_type": {
Type: schema.TypeString,
Optional: true,
ForceNew: true,
Type: schema.TypeString,
Optional: true,
ForceNew: true,
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
ValidateFunc: validation.StringInSlice([]string{"EXTERNAL", "INTERNAL", ""}, false),
DiffSuppressFunc: emptyOrDefaultStringSuppress("EXTERNAL"),
Default: "EXTERNAL",
Expand All @@ -72,23 +74,35 @@ func resourceComputeGlobalAddress() *schema.Resource {
"labels": {
Type: schema.TypeMap,
Optional: true,
Elem: &schema.Schema{Type: schema.TypeString},
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
Elem: &schema.Schema{Type: schema.TypeString},
},
"network": {
Type: schema.TypeString,
Optional: true,
ForceNew: true,
Type: schema.TypeString,
Optional: true,
ForceNew: true,
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
DiffSuppressFunc: compareSelfLinkOrResourceName,
},
"prefix_length": {
Type: schema.TypeInt,
Optional: true,
ForceNew: true,
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
},
"purpose": {
Type: schema.TypeString,
Optional: true,
ForceNew: true,
Type: schema.TypeString,
Optional: true,
ForceNew: true,
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
ValidateFunc: validation.StringInSlice([]string{"VPC_PEERING", ""}, false),
},
"address": {
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_health_check.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ func resourceComputeHealthCheck() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeHealthCheckImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_http_health_check.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ func resourceComputeHttpHealthCheck() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeHttpHealthCheckImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_https_health_check.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ func resourceComputeHttpsHealthCheck() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeHttpsHealthCheckImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_region_autoscaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ func resourceComputeRegionAutoscaler() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeRegionAutoscalerImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down
4 changes: 3 additions & 1 deletion google/resource_compute_region_disk.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ func resourceComputeRegionDisk() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeRegionDiskImport,
},

DeprecationMessage: `This resource is in beta and will be removed from this provider.
Use the ComputeRegionDisk resource in terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta resources.`,
Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(300 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_route.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ func resourceComputeRoute() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeRouteImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Delete: schema.DefaultTimeout(240 * time.Second),
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_router.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ func resourceComputeRouter() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeRouterImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_ssl_certificate.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ func resourceComputeSslCertificate() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeSslCertificateImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Delete: schema.DefaultTimeout(240 * time.Second),
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_ssl_policy.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ func resourceComputeSslPolicy() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeSslPolicyImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down
10 changes: 9 additions & 1 deletion google/resource_compute_subnetwork.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ func resourceComputeSubnetwork() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeSubnetworkImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(360 * time.Second),
Update: schema.DefaultTimeout(360 * time.Second),
Expand Down Expand Up @@ -102,6 +101,9 @@ func resourceComputeSubnetwork() *schema.Resource {
"enable_flow_logs": {
Type: schema.TypeBool,
Optional: true,
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
},
"private_ip_google_access": {
Type: schema.TypeBool,
Expand All @@ -118,6 +120,9 @@ func resourceComputeSubnetwork() *schema.Resource {
Type: schema.TypeList,
Computed: true,
Optional: true,
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"ip_cidr_range": {
Expand All @@ -140,6 +145,9 @@ func resourceComputeSubnetwork() *schema.Resource {
"fingerprint": {
Type: schema.TypeString,
Computed: true,
Deprecated: `This field is in beta and will be removed from this provider.
Use the terraform-provider-google-beta provider to continue using it.
See http://terraform.io/docs/provider/google/provider_versions.html for more details on beta fields.`,
},
"gateway_address": {
Type: schema.TypeString,
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_target_http_proxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ func resourceComputeTargetHttpProxy() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeTargetHttpProxyImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_target_https_proxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ func resourceComputeTargetHttpsProxy() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeTargetHttpsProxyImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_target_ssl_proxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ func resourceComputeTargetSslProxy() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeTargetSslProxyImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_target_tcp_proxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ func resourceComputeTargetTcpProxy() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeTargetTcpProxyImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Update: schema.DefaultTimeout(240 * time.Second),
Expand Down
1 change: 0 additions & 1 deletion google/resource_compute_vpn_gateway.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ func resourceComputeVpnGateway() *schema.Resource {
Importer: &schema.ResourceImporter{
State: resourceComputeVpnGatewayImport,
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(240 * time.Second),
Delete: schema.DefaultTimeout(240 * time.Second),
Expand Down
Loading

0 comments on commit b6f7a24

Please sign in to comment.