Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_cloudbuild_trigger missing "filter" field #10387

Labels
Milestone

Comments

@finlaye
Copy link

finlaye commented Oct 25, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The cloud build API has the option to specify a filter string https://cloud.google.com/build/docs/api/reference/rest/v1/projects.locations.triggers

"filter": string

This seems to be missing from the google terraform provider.

New or Affected Resource(s)

google_cloudbuild_trigger

  • google_XXXXX

Potential Terraform Configuration

resource "google_cloudbuild_trigger" "filename-trigger" {
  trigger_template {
    branch_name = "master"
    repo_name   = "my-repo"
  }

  substitutions = {
    _FOO = "foo-bar"
    _BAZ = "qux"
  }

  filter = "_FOO.matches(\".*-bar\")"

  filename = "cloudbuild.yaml"
}

References

@rileykarson rileykarson added this to the Goals milestone Oct 25, 2021
@smorenburg
Copy link

I'm looking forward to this enhancement. Creating the Cloud Build triggers using Terraform ain't an option right now.

@abhinavrau
Copy link

I would like to work on this issue. I have added support for it on my fork of magic-modules here. I will be submitting a PR soon

@abhinavrau
Copy link

Duplicate of #9755

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2022
@github-actions github-actions bot added service/cloudbuild forward/review In review; remove label to forward labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.