Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for manual builds, git source for webhook/pubsub triggered builds and filter field #11219

Conversation

modular-magician
Copy link
Collaborator

Fixes #10779
Fixes #10434
Fixes #10387
Fixes #9755
Fixes #8374
Fixes #9189
Fixes #9883

Add support for REST fields sourceToBuild and gitFileSource which adds support for manual builds as well as adds support for webhook and pubsub triggered builds with source code.
Also added support for filter field that is used with webhook and pubsub triggered builds.
Also added examples for webhook, pubsub (with filter) and manual build.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudbuild: Add support for manual builds, git source for webhook/pubsub triggered builds and filter field

Derived from GoogleCloudPlatform/magic-modules#5738

…d builds and filter field (hashicorp#5738)

* add filter support for cloudbuild

* Add support for sourceToBuild and gitFileSource. Add examples for pubsub_config, webhook_config trigger and manual mode

* Add support for sourceToBuild and gitFileSource. Add examples for pubsub_config, webhook_config trigger and manual mode

* Fix description for field uri in sourceToBuild to be required

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 51b2397 into hashicorp:main Mar 4, 2022
@github-actions
Copy link

github-actions bot commented Apr 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.